show schema.collate in explain(verbose on)

From: "wangsh(dot)fnst(at)fujitsu(dot)com" <wangsh(dot)fnst(at)fujitsu(dot)com>
To: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: show schema.collate in explain(verbose on)
Date: 2022-02-21 10:18:11
Message-ID: OS3PR01MB71597DEDF4C3919B42EEEB68F23A9@OS3PR01MB7159.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

The comment of get_collation_name wrote:

* NOTE: since collation name is not unique, be wary of code that uses this
* for anything except preparing error messages.

In file explain.c, the function get_collation_name() is called, but the schema
name won't be outputted.

Since the schema name of relation/function name will be outputted in
explain's result when verbose(on) is specified. I plan to output the schema
name of collation as well as relation/function.

The patch attached, any thought?

Regards
Shenhao Wang

Attachment Content-Type Size
0001-show-schema-name-of-collation-in-explain-verbose.patch application/octet-stream 6.6 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Drouvot, Bertrand 2022-02-21 10:29:51 Re: [BUG] Logical replication failure "ERROR: could not map filenode "base/13237/442428" to relation OID" with catalog modifying txns
Previous Message osumi.takamichi@fujitsu.com 2022-02-21 10:06:17 RE: Failed transaction statistics to measure the logical replication progress