| From: | "wangw(dot)fnst(at)fujitsu(dot)com" <wangw(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "Takamichi Osumi (Fujitsu)" <osumi(dot)takamichi(at)fujitsu(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, Fabrice Chapuis <fabrice636861(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Petr Jelinek <petr(dot)jelinek(at)enterprisedb(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Ajin Cherian <itsajin(at)gmail(dot)com> |
| Subject: | RE: Rework LogicalOutputPluginWriterUpdateProgress |
| Date: | 2023-03-10 09:32:28 |
| Message-ID: | OS3PR01MB62756F9BDAE15D08C24BF4379EBA9@OS3PR01MB6275.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 10, 2023 11:56 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Wed, Mar 8, 2023 at 8:24 AM wangw(dot)fnst(at)fujitsu(dot)com
> <wangw(dot)fnst(at)fujitsu(dot)com> wrote:
> >
> > Attach the new patch.
> >
>
> I think this combines multiple improvements in one patch. We can
> consider all of them together or maybe it would be better to split
> some of those. Do we think it makes sense to split some of the
> improvements? I could think of below:
>
> 1. Remove SyncRepRequested() check from WalSndUpdateProgress().
> 2. Add check of wal_sender_timeout > 0 in WalSndUpdateProgress() and
> any other similar place.
> 3. Change the name of ProcessPendingWrites() to WalSndSendPending().
> 4. Change WalSndUpdateProgress() to WalSndUpdateProgressAndKeepalive().
> 5. The remaining patch.
I think it would help to review different improvements separately, so I split
the patch as suggested.
Also addressed the comments by Kuroda-san, Osumi-san and Peter.
Attach the new patch set.
Regards,
Wang wei
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-Remove-SyncRepRequested-check-from-WalSndUpdatePr.patch | application/octet-stream | 958 bytes |
| v7-0002-Check-wal_sender_timeout-is-in-effect-before-usin.patch | application/octet-stream | 1.5 KB |
| v7-0003-Rename-the-function-ProcessPendingWrites-to-WalSn.patch | application/octet-stream | 1.8 KB |
| v7-0004-Rename-the-function-WalSndUpdateProgress-to-WalSn.patch | application/octet-stream | 10.0 KB |
| v7-0005-Rework-LogicalOutputPluginWriterUpdateProgressAnd.patch | application/octet-stream | 34.2 KB |
| v7-0006-Catch-the-absence-of-commit-rollback_prepared_cb_.patch | application/octet-stream | 3.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | wangw.fnst@fujitsu.com | 2023-03-10 09:33:42 | RE: Rework LogicalOutputPluginWriterUpdateProgress |
| Previous Message | Katsuragi Yuta | 2023-03-10 09:07:53 | Re: [Proposal] Add foreign-server health checks infrastructure |