RE: Skipping logical replication transactions on subscriber side

From: "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Greg Nancarrow <gregn4422(at)gmail(dot)com>, "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Alexey Lesovsky <lesovsky(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: RE: Skipping logical replication transactions on subscriber side
Date: 2021-08-24 06:13:55
Message-ID: OS0PR01MB6113C654571DD0081D45D934FBC59@OS0PR01MB6113.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Monday, August 23, 2021 11:09 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> I've attached updated patches. Please review them.
>

I tested v10-0001 patch in both streaming and no-streaming more. All tests works well.

I also tried two-phase commit feature, the error context was set as expected,
but please allow me to propose a fix suggestion on the error description:

CONTEXT: processing remote data during "INSERT" for replication target relation
"public.test" in transaction 714 with commit timestamp 2021-08-24
13:20:22.480532+08

It said "commit timestamp", but for 2pc feature, the timestamp could be "prepare timestamp" or "rollback timestamp", too.
Could we make some change to make the error log more comprehensive?

Regards
Tang

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dinesh Chemuduru 2021-08-24 06:16:33 Re: [PROPOSAL] new diagnostic items for the dynamic sql
Previous Message Kyotaro Horiguchi 2021-08-24 06:12:28 Re: pgstat_send_connstats() introduces unnecessary timestamp and UDP overhead