| From: | "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Subject: | RE: Added schema level support for publication. |
| Date: | 2021-08-26 02:22:44 |
| Message-ID: | OS0PR01MB6113C424DCDA0950BE34B5B8FBC79@OS0PR01MB6113.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wednesday, August 25, 2021 5:37 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> Attached v21 patch has the changes based on the new syntax and fixes
> few of the other review comments provided by reviewers.
>
Thanks for your new patch. I saw the following warning when building, please have a look.
publicationcmds.c: In function ‘ConvertPubObjSpecListToOidList’:
publicationcmds.c:212:23: warning: ‘prevobjtype’ may be used uninitialized in this function [-Wmaybe-uninitialized]
pubobj->pubobjtype = prevobjtype;
~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
Regards
Tang
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2021-08-26 02:48:58 | Re: Mark all GUC variable as PGDLLIMPORT |
| Previous Message | Ajin Cherian | 2021-08-26 02:07:53 | Re: Failure of subscription tests with topminnow |