| From: | "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | RE: Remove "FROM" in "DELETE FROM" when using tab-completion |
| Date: | 2021-05-11 07:30:47 |
| Message-ID: | OS0PR01MB6113B2E34CD215404BC00E1DFB539@OS0PR01MB6113.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tuesday, May 11, 2021 2:53 PM, Michael Paquier <michael(at)paquier(dot)xyz> wrote
> else if (TailMatches("DELETE", "FROM", MatchAny))
> COMPLETE_WITH("USING", "WHERE");
>- /* XXX: implement tab completion for DELETE ... USING */
>
>Why are you removing that? This sentence is still true, no?
IIRC, XXX in comment is used to flag something that is bogus but works.
When the sentence introduced here in f5ab0a14, the fix for "DELETE ... USING" is not as good as it is now.(I guess that's why the comment was added). And for now, IMHO, we can remove the comment directly.
If my understanding here is wrong, please let me know and that would be great to learn more about PG.
Regards,
Tang
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2021-05-11 07:35:39 | Re: compute_query_id and pg_stat_statements |
| Previous Message | Michael Paquier | 2021-05-11 07:29:28 | Re: Multiple hosts in connection string failed to failover in non-hot standby mode |