| From: | "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com> |
| Cc: | Ajin Cherian <itsajin(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Önder Kalacı <onderkalaci(at)gmail(dot)com>, japin <japinli(at)hotmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, David Steele <david(at)pgmasters(dot)net>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: row filtering for logical replication |
| Date: | 2021-11-23 05:40:02 |
| Message-ID: | OS0PR01MB611389E3A5685B53930A4833FB609@OS0PR01MB6113.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thursday, November 18, 2021 9:34 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> PSA new set of v40* patches.
>
I found a problem on v40. The check for Replica Identity in WHERE clause is not working properly.
For example:
postgres=# create table tbl(a int primary key, b int);
CREATE TABLE
postgres=# create publication pub1 for table tbl where (a>10 and b>10);
CREATE PUBLICATION
I think it should report an error because column b is not part of Replica Identity.
This seems due to "return true" in rowfilter_expr_replident_walker function,
maybe we should remove it.
Besides, a small comment on 0004 patch:
+ * Multiple row-filter expressions for the same publication will later be
+ * combined by the COPY using OR, but this means if any of the filters is
Should we change it to:
Multiple row-filter expressions for the same table ...
Regards,
Tang
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2021-11-23 05:49:02 | Re: Removing more vacuumlazy.c special cases, relfrozenxid optimizations |
| Previous Message | Bharath Rupireddy | 2021-11-23 05:09:26 | pg_replslotdata - a tool for displaying replication slot information |