| From: | "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | RE: [BUG]Update Toast data failure in logical replication |
| Date: | 2021-05-31 10:03:54 |
| Message-ID: | OS0PR01MB61137DE0A63EC2AD65CFB35AFB3F9@OS0PR01MB6113.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, May 31, 2021 5:12 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
> The problem is if the key attribute is not changed we don't log it as
> it should get logged along with the updated tuple, but if it is
> externally stored then the complete key will never be logged because
> there is no log from the toast table. For fixing this if the key is
> externally stored then always log that.
>
> Please test with the attached patch.
Thanks for your patch. I tested it and the bug was fixed.
I'm still trying to understand your fix, please allow me to ask more(maybe silly) questions if I found any.
+ * if the key hasn't changedand we're only logging the key, we're done.
I think "changedand" should be "changed and".
Regards
Tang
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2021-05-31 10:09:01 | Re: [BUG]Update Toast data failure in logical replication |
| Previous Message | Esteban Zimanyi | 2021-05-31 09:32:19 | Re: How to disable the autovacuum ? |