RE: [PATCH] support tab-completion for single quote input with equal sign

From: "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>
To: Jacob Champion <pchampion(at)vmware(dot)com>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: [PATCH] support tab-completion for single quote input with equal sign
Date: 2021-09-03 04:32:49
Message-ID: OS0PR01MB611358D336513EEECE7DE4B0FBCF9@OS0PR01MB6113.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Friday, September 3, 2021 2:14 AM, Jacob Champion <pchampion(at)vmware(dot)com> wrote
>I applied your patch against HEAD (and did a clean build for good
>measure) but couldn't get the tab-completion you described -- on my
>machine, `PUBLICATION` still fails to complete. Tab completion is
>working in general, for example with the `SUBSCRIPTION` and
>`CONNECTION` keywords.
>
>Is there additional setup that I need to do?

Thanks for your check.

I applied the 0001-patch to the HEAD(c95ede41) by now and it worked as I expected.
Did you leave a space between "dbname=postgres'" and "[TAB]"?

In 0002-patch I added a tap test for the scenario of single quoted input with equal sign.
The test result is 'All tests successful. ' on my machine.
You can run the tap tests as follows:
1. Apply the attached patch
2. build the src with option '--enable-tap-tests' (./configure --enable-tap-tests)
3. Move to src subdirectory 'src/bin/psql'
4. Run 'make check'

I'd appreciate it if you can share your test results with me.

Regards,
Tang

Attachment Content-Type Size
v2-0001-support-tab-completion-for-single-quote-input-wit.patch application/octet-stream 2.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2021-09-03 04:52:53 Re: using an end-of-recovery record in all cases
Previous Message Andrey Borodin 2021-09-03 04:11:16 Re: suboverflowed subtransactions concurrency performance optimize