| From: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Smith <smithpb2250(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | RE: Added schema level support for publication. |
| Date: | 2021-11-03 05:37:48 |
| Message-ID: | OS0PR01MB5716EE91AF9B23ACD11846D1948C9@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 3, 2021 12:25 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> On Wed, Nov 3, 2021 at 8:30 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
> wrote:
> >
> > On Tue, Nov 2, 2021 at 8:13 PM Tomas Vondra
> > <tomas(dot)vondra(at)enterprisedb(dot)com> wrote:
> > >
> > >
> > > >
> > > > Yeah, that is also true. So maybe at this, we can just rename the
> > > > few types as suggested by you and we can look at it later if we
> > > > anytime have more number of objects to add.
> > > >
> > >
> > > +1
> > >
> >
> > Apart from what you have pointed above, we are using
> > "DO_PUBLICATION_REL_IN_SCHEMA" in pg_dump. I think we should replace
> > that as well with "DO_PUBLICATION_TABLE_IN_SCHEMA".
>
> Thanks for the comments, the attached patch has the changes for the same.
>
Thanks for the patch.
I have only one minor comment:
+ PUBLICATIONOBJ_TABLE_IN_SCHEMA, /* Relations in schema type */
I think the ' Relations' in the comments also need to be changed to 'tables'.
The other part of the patch looks good to me.
Best regards,
Hou zj
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-11-03 05:55:12 | Re: Logical insert/update/delete WAL records for custom table AMs |
| Previous Message | Thomas Munro | 2021-11-03 04:41:47 | Re: [PATCH] Native spinlock support on RISC-V |