| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | RE: Conflict detection for update_deleted in logical replication |
| Date: | 2025-06-26 03:01:21 |
| Message-ID: | OS0PR01MB5716E48EED369CF34798DD0D947AA@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 25, 2025 at 2:57 PM shveta malik wrote:
>
> >
> > Here is the V41 patch set which includes the following changes:
> >
>
> Thanks for the patches. Few trivial things:
>
> 1)
> In ReplicationSlotAcquire(), does it make more sense to move the error after
> checking the slot's existence first? If a user is trying to use a slot which does
> not exist, he should first get that error instead of 'slot is reserved' error.
>
> 2)
> When max_replication_slots limit is reached and user is trying to enable rci for
> the first time, launcher will give error in log file:
>
> ERROR: all replication slots are in use
> HINT: Free one or increase "max_replication_slots".
> LOG: background worker "logical replication launcher" (PID 13147) exited
> with exit code 1
>
> It is not clear from this message as to what launcher was actually trying to
> create. A log-msg in CreateConflictDetectionSlot() saying "Creating
> conflict-detection slot" may help here.
Thanks for the comments. All of them look good to me and
have been addressed in V42.
Best Regards,
Hou zj
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhijie Hou (Fujitsu) | 2025-06-26 03:02:01 | RE: Conflict detection for update_deleted in logical replication |
| Previous Message | Hayato Kuroda (Fujitsu) | 2025-06-26 02:20:05 | RE: pg_logical_slot_get_changes waits continously for a partial WAL record spanning across 2 pages |