RE: Avoid CommandCounterIncrement in RI trigger when INSERT INTO referencing table

From: "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>
To: "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: Avoid CommandCounterIncrement in RI trigger when INSERT INTO referencing table
Date: 2021-03-05 06:57:06
Message-ID: OS0PR01MB5716CBBF46F99CD68EC0C41594969@OS0PR01MB5716.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> > > I'm worried about having this dependency in RI check, because the
> > > planner
> > may allow parallel INSERT in these cases in the future.
> >
> > If we support parallel insert that can have other modifications in the
> > future, I think we will also be able to share or increment command ID
> > in parallel wokers in that time.
> > And it seems we can remove this dependency in that time.
> > How about add some more comments about this to remind future
> developer.
> > /*
> > * If extra parallel modification is support in the future, this
> > dependency should be removed.
> > */
>
> Agreed.
>
> I'm excited to see PostgreSQL's parallel DML work in wider use cases and
> satisfy users' expectations.

Thanks !
Attaching the first version patch which avoid CCI in RI trigger when insert into referencing table.

Best regards,
houzj

Attachment Content-Type Size
0001-Avoid-CCI-in-RI-trigger-when-INSERT-fk-relation.patch application/octet-stream 5.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Julien Rouhaud 2021-03-05 06:59:49 Re: n_mod_since_analyze isn't reset at table truncation
Previous Message Ajin Cherian 2021-03-05 06:50:42 Re: [HACKERS] logical decoding of two-phase transactions