| From: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "vignesh21(at)gmail(dot)com" <vignesh21(at)gmail(dot)com>, "amit(dot)kapila16(at)gmail(dot)com" <amit(dot)kapila16(at)gmail(dot)com>, "sawada(dot)mshk(at)gmail(dot)com" <sawada(dot)mshk(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, 'Greg Nancarrow' <gregn4422(at)gmail(dot)com> |
| Subject: | RE: Failed transaction statistics to measure the logical replication progress |
| Date: | 2022-01-03 05:46:24 |
| Message-ID: | OS0PR01MB5716C8D244053D1CC246A83494499@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wednesday, December 22, 2021 6:14 PM Osumi, Takamichi <osumi(dot)takamichi(at)fujitsu(dot)com> wrote:
> Attached the new patch v19.
Hi,
Thanks for updating the patch.
--- a/src/include/pgstat.h
+++ b/src/include/pgstat.h
@@ -15,6 +15,7 @@
#include "portability/instr_time.h"
#include "postmaster/pgarch.h" /* for MAX_XFN_CHARS */
#include "replication/logicalproto.h"
+#include "replication/worker_internal.h"
I noticed that the patch includes "worker_internal.h " in pgstat.h.
I think it might be better to only include this file in pgstat.c.
And it seems we can access MyLogicalRepWorker directly in the
following functions instead of passing a parameter.
+extern void pgstat_report_subworker_xact_end(LogicalRepWorker *repWorker,
+ LogicalRepMsgType command,
+ bool bforce);
+extern void pgstat_send_subworker_xact_stats(LogicalRepWorker *repWorker,
+ bool force);
Best regards,
Hou zj
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2022-01-03 06:47:22 | Use MaxLockMode in lock methods initialization |
| Previous Message | SATYANARAYANA NARLAPURAM | 2022-01-03 05:27:43 | pg_receivewal fail to streams when the partial file to write is not fully initialized present in the wal receiver directory |