RE: [BUG] Unexpected action when publishing partition tables

From: "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Langote <amitlangote09(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Subject: RE: [BUG] Unexpected action when publishing partition tables
Date: 2021-09-16 01:45:13
Message-ID: OS0PR01MB5716A07CE2B3B2F30A626D0594DC9@OS0PR01MB5716.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tuesday, September 14, 2021 10:41 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> On Tue, Sep 7, 2021 at 11:38 AM houzj(dot)fnst(at)fujitsu(dot)com <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
> >
> >
> > Attach new version patches which addressed the comment.
>
> Thanks for fixing this issue. The bug gets fixed by the patch, I did not find any
> issues in my testing.
> I just had one minor comment:
>
> We could clean the table at the end by calling DROP TABLE testpub_parted2:
> +-- still fail, because parent's publication replicates updates UPDATE
> +testpub_parted2 SET a = 2;
> +ERROR: cannot update table "testpub_parted2" because it does not
> have a replica identity and publishes updates
> +HINT: To enable updating the table, set REPLICA IDENTITY using ALTER
> TABLE.
> +ALTER PUBLICATION testpub_forparted DROP TABLE testpub_parted;
> +-- works again, because update is no longer replicated UPDATE
> +testpub_parted2 SET a = 2;

Thanks for the comment.
Attach new version patches which clean the table at the end.

Best regards,
Hou zj

Attachment Content-Type Size
v3-0001-Made-the-existing-relation-cache-invalidation-an.patch application/octet-stream 5.8 KB
v3-0002-Invalidate-all-partitions.patch application/octet-stream 8.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message houzj.fnst@fujitsu.com 2021-09-16 02:06:09 RE: Column Filtering in Logical Replication
Previous Message houzj.fnst@fujitsu.com 2021-09-16 00:59:37 RE: Logical replication keepalive flood