RE: Conflict detection for update_deleted in logical replication

On Mon, Jun 30, 2025 at 7:22 PM Amit Kapila wrote:
>
> On Fri, Jun 27, 2025 at 7:58 AM Zhijie Hou (Fujitsu) <houzj(dot)fnst(at)fujitsu(dot)com>
> wrote:
> >
> > Here is the V43 patch set which includes the following changes:
> >
>
> Few minor comments:
> 1.
> @@ -29645,8 +29651,10 @@ postgres=# SELECT '0/0'::pg_lsn +
> pd.segment_number * ps.setting::int + :offset
> Copies an existing logical replication slot
> named <parameter>src_slot_name</parameter> to a logical
> replication
> slot named <parameter>dst_slot_name</parameter>, optionally
> changing
> - the output plugin and persistence. The copied logical slot starts
> - from the same <acronym>LSN</acronym> as the source logical slot.
> Both
> + the output plugin and persistence. The name cannot be
> + <literal>pg_conflict_detection</literal> as it is reserved for
> + the conflict detection. The copied logical slot starts from the same
> + <acronym>LSN</acronym> as the source logical slot. Both
>
> /The name/The new slot name
>
> 2. The server version checks can be modified to 19000 as a new branch is
> created now.
>
> 3.
> This ensures that if the launcher loses track of the slot after
> +   * a restart, it will remember to drop the slot when it is no longer
> +   * requested by any subscription.
>
> The link between the first part of the sentence before the comma is not clear
> with the remaining part of the sentence. How about writing it as: "Acquire the
> conflict detection slot at startup to ensure it can be dropped if no longer needed
> after a restart."?

Thanks for the comments. I have addressed above in V44 patch set.

Only 0001 is modified in this version.

Best Regards,
Hou zj