RE: wake up logical workers after ALTER SUBSCRIPTION

On Monday, January 23, 2023 3:13 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

Hi,

>
> Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
> > On Tue, Jan 10, 2023 at 10:59:14AM +0530, Amit Kapila wrote:
> >> I haven't looked in detail but isn't it better to explain somewhere
> >> in the comments that it achieves to rate limit the restart of workers
> >> in case of error and allows them to restart immediately in case of
> >> subscription parameter change?
>
> > I expanded one of the existing comments to make this clear.
>
> I pushed v17 with some mostly-cosmetic changes, including more comments.

I noticed one minor thing in this commit.

-
LogicalRepCtx->last_start_dsh = DSM_HANDLE_INVALID;
-

The code takes the last_start_dsh as dsm_handle, but it seems it is a dsa_pointer.
" typedef dsa_pointer dshash_table_handle;" This won’t cause any problem, but I feel
It would be easier to understand if we take it as dsa_pointer and use InvalidDsaPointer here,
like what he attached patch does. What do you think ?

Best regards,
Hou zj