| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: wake up logical workers after ALTER SUBSCRIPTION |
| Date: | 2023-01-24 17:13:29 |
| Message-ID: | 20230124171329.GA677220@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 24, 2023 at 02:55:07AM +0000, houzj(dot)fnst(at)fujitsu(dot)com wrote:
> I noticed one minor thing in this commit.
>
> -
> LogicalRepCtx->last_start_dsh = DSM_HANDLE_INVALID;
> -
>
> The code takes the last_start_dsh as dsm_handle, but it seems it is a dsa_pointer.
> " typedef dsa_pointer dshash_table_handle;" This won’t cause any problem, but I feel
> It would be easier to understand if we take it as dsa_pointer and use InvalidDsaPointer here,
> like what he attached patch does. What do you think ?
IMO ideally there should be a DSA_HANDLE_INVALID and DSHASH_HANDLE_INVALID
for use with dsa_handle and dshash_table_handle, respectively. But your
patch does seem like an improvement.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2023-01-24 17:16:02 | Re: psql: Add role's membership options to the \du+ command |
| Previous Message | Andrew Dunstan | 2023-01-24 17:00:12 | Re: run pgindent on a regular basis / scripted manner |