| From: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Japin Li <japinli(at)hotmail(dot)com> |
| Subject: | RE: Improve errhint for ALTER SUBSCRIPTION ADD/DROP PUBLICATION |
| Date: | 2022-10-19 01:51:37 |
| Message-ID: | OS0PR01MB5716731176566D59D8D4F22B942B9@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tuesday, October 18, 2022 5:50 PM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> On 2022-Oct-18, Japin Li wrote:
>
> >
> > On Tue, 18 Oct 2022 at 12:00, houzj(dot)fnst(at)fujitsu(dot)com
> <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
> >
> > > Agreed. Here is new version patch which changed the error code and
> > > moved the whole command out of the message according to Álvaro's
> comment.
> >
> > My bad! The patch looks good to me.
>
> Thank you, I pushed it to both branches, because I realized we were saying "SET
> PUBLICATION" when we meant "ADD/DROP"; that hint could be quite
> damaging if anybody decides to actually follow it ISTM.
Thanks for pushing!
Best regards,
Hou zj
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2022-10-19 02:10:30 | Re: pub/sub - specifying optional parameters without values. |
| Previous Message | Peter Smith | 2022-10-19 01:46:42 | Re: Fix typo in code comment |