| From: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | David Steele <david(at)pgmasters(dot)net>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Add Nullif case for eval_const_expressions_mutator |
| Date: | 2021-03-24 10:52:04 |
| Message-ID: | OS0PR01MB571671733EA40F95FF45169D94639@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> + if (!has_nonconst_input)
> + return ece_evaluate_expr(expr);
>
> That's not okay without a further check to see if the comparison function used
> by the node is immutable. Compare ScalarArrayOpExpr, for instance.
Thanks for pointing it out.
Attaching new patch with this change.
Best regards,
houzj
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-add-nullif-case-for-eval_const_expressions.patch | application/octet-stream | 3.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | houzj.fnst@fujitsu.com | 2021-03-24 10:52:14 | RE: fix typo in reorderbuffer.c |
| Previous Message | houzj.fnst@fujitsu.com | 2021-03-24 10:29:31 | RE: [HACKERS] logical decoding of two-phase transactions |