From: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
---|---|
To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com>, Alexey Lesovsky <lesovsky(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Greg Nancarrow <gregn4422(at)gmail(dot)com> |
Subject: | RE: Skipping logical replication transactions on subscriber side |
Date: | 2021-10-20 03:02:55 |
Message-ID: | OS0PR01MB5716706D7F0DDC318103150B94BE9@OS0PR01MB5716.jpnprd01.prod.outlook.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Oct 18, 2021 9:34 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> I've attached updated patches that incorporate all comments I got so far.
Hi,
Here are some minor comments for the patches.
v17-0001-Add-a-subscription-errors-statistics-view-pg_sta.patch
1)
+ /* Clean up */
+ if (not_ready_rels != NIL)
+ list_free_deep(not_ready_rels);
Maybe we don't need the ' if (not_ready_rels != NIL)' check as
list_free_deep will do this check internally.
2)
+ for (int i = 0; i < msg->m_nentries; i++)
+ {
+ HASH_SEQ_STATUS sstat;
+ PgStat_StatSubWorkerEntry *wentry;
+
+ /* Remove all worker statistics of the subscription */
+ hash_seq_init(&sstat, subWorkerStatHash);
+ while ((wentry = (PgStat_StatSubWorkerEntry *) hash_seq_search(&sstat)) != NULL)
+ {
+ if (wentry->key.subid == msg->m_subids[i])
+ (void) hash_search(subWorkerStatHash, (void *) &(wentry->key),
+ HASH_REMOVE, NULL);
Would it be a little faster if we scan hashtable in outerloop and
scan the msg in innerloop ?
Like:
while ((wentry = (PgStat_StatSubWorkerEntry *) hash_seq_search(&sstat)) != NULL)
{
for (int i = 0; i < msg->m_nentries; i++)
...
v17-0002-Add-RESET-command-to-ALTER-SUBSCRIPTION-command
1)
I noticed that we cannot RESET slot_name while we can SET it.
And the slot_name have a default behavior that " use the name of the subscription for the slot name.".
So, is it possible to support RESET it ?
Best regards,
Hou zj
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2021-10-20 03:22:58 | Re: Postgres perl module namespace |
Previous Message | Ajin Cherian | 2021-10-20 02:58:56 | Re: row filtering for logical replication |