RE: Parallel Inserts (WAS: [bug?] Missed parallel safety checks..)

From: "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Greg Nancarrow <gregn4422(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: Parallel Inserts (WAS: [bug?] Missed parallel safety checks..)
Date: 2021-09-09 02:12:08
Message-ID: OS0PR01MB57163642B64310CEB295CD4E94D59@OS0PR01MB5716.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

From: Wednesday, September 1, 2021 5:24 PM Hou Zhijie<houzj(dot)fnst(at)fujitsu(dot)com>
> Thursday, August 19, 2021 4:16 PM Hou zhijie <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
> > On Fri, Aug 6, 2021 4:23 PM Hou zhijie <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
> > >
> > > Update the commit message in patches to make it easier for others to
> review.
> >
> > CFbot reported a compile error due to recent commit 3aafc03.
> > Attach rebased patches which fix the error.
>
> The patch can't apply to the HEAD branch due a recent commit.
> Attach rebased patches.

In the past, the rewriter could generate a re-written query with a modifying
CTE does not have hasModifyingCTE flag set and this bug cause the regression
test(force_parallel_mode=regress) failure when enable parallel select for
insert, so , we had a workaround 0006.patch for it. But now, the bug has been
fixed in commit 362e2d and we don't need the workaround patch anymore.

Attach new version patch set which remove the workaround patch.

Best regards,
Hou zj

Attachment Content-Type Size
v19-0002-Parallel-SELECT-for-INSERT.patch application/octet-stream 9.9 KB
v19-0003-Get-parallel-safety-functions.patch application/octet-stream 31.8 KB
v19-0004-Cache-parallel-dml-safety.patch application/octet-stream 12.3 KB
v19-0005-Regression-test-and-doc-updates.patch application/octet-stream 110.8 KB
v19-0001-CREATE-ALTER-TABLE-PARALLEL-DML.patch application/octet-stream 44.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-09-09 02:17:01 Re: Add jsonlog log_destination for JSON server logs
Previous Message Michael Paquier 2021-09-09 01:32:00 Re: [PATCH] test/ssl: rework the sslfiles Makefile target