| From: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Andy Fan <zhihui(dot)fan1213(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Zhihong Yu <zyu(at)yugabyte(dot)com> |
| Subject: | RE: Hybrid Hash/Nested Loop joins and caching results from subplans |
| Date: | 2021-04-01 10:41:30 |
| Message-ID: | OS0PR01MB571633F368DF53C730C3E9CA947B9@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> I've attached the updated patch. I'll let the CFbot grab this to ensure it's
> happy with it before I go looking to push it again.
Hi,
I took a look into the patch and noticed some minor things.
1.
+ case T_ResultCache:
+ ptype = "ResultCache";
+ subpath = ((ResultCachePath *) path)->subpath;
+ break;
case T_UniquePath:
ptype = "Unique";
subpath = ((UniquePath *) path)->subpath;
should we use "case T_ResultCachePath" here?
2.
Is it better to add ResultCache's info to " src/backend/optimizer/README " ?
Something like:
NestPath - nested-loop joins
MergePath - merge joins
HashPath - hash joins
+ ResultCachePath - Result cache
Best regards,
Hou zhijie
| From | Date | Subject | |
|---|---|---|---|
| Next Message | yuzuko | 2021-04-01 11:34:53 | Re: Autovacuum on partitioned table (autoanalyze) |
| Previous Message | David Rowley | 2021-04-01 10:23:05 | Re: Hybrid Hash/Nested Loop joins and caching results from subplans |