RE: row filtering for logical replication

From: "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Önder Kalacı <onderkalaci(at)gmail(dot)com>, japin <japinli(at)hotmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, David Steele <david(at)pgmasters(dot)net>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: row filtering for logical replication
Date: 2022-01-13 13:20:37
Message-ID: OS0PR01MB571611F828866EA7B22AE96594539@OS0PR01MB5716.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thur, Jan 13, 2022 5:22 PM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> > /*
> > + * Only 3 publication actions are used for row filtering ("insert",
> > +"update",
> > + * "delete"). See RelationSyncEntry.exprstate[].
> > + */
> > +typedef enum RowFilterPubAction
> > +{
> > + PUBACTION_INSERT,
> > + PUBACTION_UPDATE,
> > + PUBACTION_DELETE,
> > + NUM_ROWFILTER_PUBACTIONS /* must be last */ }
> RowFilterPubAction;
>
> Please do not add NUM_ROWFILTER_PUBACTIONS as an enum value. It's a bit
> of a lie and confuses things, because your enum now has 4 possible values, not
> 3. I suggest to #define NUM_ROWFILTER_PUBACTIONS
> (PUBACTION_DELETE+1) instead.
>
> > + int idx_ins = PUBACTION_INSERT;
> > + int idx_upd = PUBACTION_UPDATE;
> > + int idx_del = PUBACTION_DELETE;
>
> I don't understand the purpose of these variables; can't you just use the
> constants?

Thanks for the comments !
Changed the code as suggested.

Best regards,
Hou zj

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Borisov 2022-01-13 13:21:06 Re: UNIQUE null treatment option
Previous Message houzj.fnst@fujitsu.com 2022-01-13 13:16:33 RE: row filtering for logical replication