| From: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | "ikedamsh(at)oss(dot)nttdata(dot)com" <ikedamsh(at)oss(dot)nttdata(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, 'Fujii Masao' <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, 'Kyotaro Horiguchi' <horikyota(dot)ntt(at)gmail(dot)com> |
| Subject: | RE: Allow escape in application_name |
| Date: | 2021-09-10 03:35:39 |
| Message-ID: | OS0PR01MB57160DDB953021E95C9CA4D494D69@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
From Friday, September 10, 2021 11:24 AM kuroda(dot)hayato(at)fujitsu(dot)com <kuroda(dot)hayato(at)fujitsu(dot)com>
> > We can simplify the code as follows.
> >
> > if (values[i] != '\0')
> > break;
>
> Fixed. And type mismatching was also fixed.
>
> > IMO it's better to use process_padding() to process log_line_prefix
> > and postgres_fdw.application in the same way as possible.
> > Which would be less confusing.
>
> OK, I followed that. Some comments were added above the function.
Hi Kuroda-san,
I found one minor thing in the patch.
+ appendStringInfoSpaces(buf,
+ padding > 0 ? padding : -padding);
Is it better to use Abs(padding) here ?
Although some existing codes are using " padding > 0 ? padding : -padding ".
Best regards,
Hou zj
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-09-10 04:07:00 | Re: Add jsonlog log_destination for JSON server logs |
| Previous Message | kuroda.hayato@fujitsu.com | 2021-09-10 03:24:11 | RE: Allow escape in application_name |