[PATCH][BUG FIX] Uninitialized variable parsed

From: Ranier Vilela <ranier_gyn(at)hotmail(dot)com>
To: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: [PATCH][BUG FIX] Uninitialized variable parsed
Date: 2019-11-22 16:50:45
Message-ID: MN2PR18MB2927C646DF2B4F4830E4AE1EE3490@MN2PR18MB2927.namprd18.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,
Typo mystake?
Memset only fill a pointer size, not the size of struct.

Best regards.
Ranier Vilela

--- \dll\postgresql-12.0\a\backend\access\rmgrdesc\xactdesc.c Mon Sep 30 17:06:55 2019
+++ xactdesc.c Fri Nov 22 13:40:13 2019
@@ -35,7 +35,7 @@
{
char *data = ((char *) xlrec) + MinSizeOfXactCommit;

- memset(parsed, 0, sizeof(*parsed));
+ memset(parsed, 0, sizeof(xl_xact_parsed_commit));

parsed->xinfo = 0; /* default, if no XLOG_XACT_HAS_INFO is
* present */
@@ -130,7 +130,7 @@
{
char *data = ((char *) xlrec) + MinSizeOfXactAbort;

- memset(parsed, 0, sizeof(*parsed));
+ memset(parsed, 0, sizeof(xl_xact_parsed_commit));

parsed->xinfo = 0; /* default, if no XLOG_XACT_HAS_INFO is
* present */

Attachment Content-Type Size
xactdesc.c.patch application/octet-stream 666 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2019-11-22 16:57:12 Re: range_agg
Previous Message Paul A Jungwirth 2019-11-22 16:25:41 Re: range_agg