RE: [Proposal] Level4 Warnings show many shadow vars

From: Ranier Vilela <ranier_gyn(at)hotmail(dot)com>
To: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: RE: [Proposal] Level4 Warnings show many shadow vars
Date: 2019-12-06 12:59:15
Message-ID: MN2PR18MB29274D73FAD7AD3214B35F60E35F0@MN2PR18MB2927.namprd18.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

De: Mark Dilger <hornschnorter(at)gmail(dot)com>
Enviado: quinta-feira, 5 de dezembro de 2019 21:06
>I suggested increasing the default warnings in an email some time ago,
>to which Tom made reasonable objections. You might want to take a
>look at his comments, and consider if you can overcome the concerns
>he had:
I understand Tom's considerations.
What I mean is, everyone already knows, it's easier and safer to fix this kind of mistake early.
I'll do as Robert asked, but as with global variables, it's hard to fix.
What did the original author want, use the global variable or not use it by overriding the name.
If it was to use the global variable, it will affect the behavior of the function, I believe.

regards,
Ranier Vilela

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jakob Egger 2019-12-06 13:25:46 Frontend/Backend Protocol: SSL / GSS Protocol Negotiation Problem
Previous Message Amit Kapila 2019-12-06 12:00:01 Re: segmentation fault when cassert enabled