| From: | Steven Niu <niushiji(at)gmail(dot)com> |
|---|---|
| To: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | remove obsolete comment in AtEOXact_Inval |
| Date: | 2025-10-27 02:43:51 |
| Message-ID: | MN2PR15MB30219837B2381AE2518A4C45A7FCA@MN2PR15MB3021.namprd15.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, Hackers,
When I read the code, I noticed there is one line of comment in function AtEOXact_Inval() which is obviously obsolete.
"This should be called as the last step in processing a transaction"
AtEOXact_Inval() is called in CommitTransaction() and AbortTransaction() and there are many other steps after function AtEOXact_Inval() is called.
Such as:
AtCommit_Notify();
AtEOXact_GUC(true, 1);
AtEOXact_SPI(true);
AtEOXact_Enum();
AtEOXact_on_commit_actions(true);
AtEOXact_Namespace(true, is_parallel_worker);
AtEOXact_SMgr();
AtEOXact_Files(true);
AtEOXact_ComboCid();
AtEOXact_HashTables(true);
AtEOXact_PgStat(true, is_parallel_worker);
AtEOXact_Snapshot(true, false);
AtEOXact_ApplyLauncher(true);
AtEOXact_LogicalRepWorkers(true);
So that comment is no longer true. I made a patch to remove it as attached.
Best Regards,
Steven
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-PATCH-remove-obsolete-comment-in-AtEOXact_Inval.patch | application/octet-stream | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhijie Hou (Fujitsu) | 2025-10-27 02:53:09 | RE: Logical Replication of sequences |
| Previous Message | Peter Smith | 2025-10-27 02:14:20 | Re: POC: enable logical decoding when wal_level = 'replica' without a server restart |