Re: Tab complete for CREATE SUBSCRIPTION ... CONECTION does not work

From: Japin Li <japinli(at)hotmail(dot)com>
To: Japin Li <japinli(at)hotmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Tab complete for CREATE SUBSCRIPTION ... CONECTION does not work
Date: 2022-09-22 15:08:53
Message-ID: MEYP282MB1669A4EFDE76E48B24D6292DB64E9@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On Tue, 20 Sep 2022 at 00:19, Japin Li <japinli(at)hotmail(dot)com> wrote:
> Hi hacker,
>
> As $subject detailed, the tab-complete cannot work such as:
>
> CREATE SUBSCRIPTION sub CONNECTION 'dbname=postgres port=6543' \t
>
> It seems that the get_previous_words() could not parse the single quote.
>
> OTOH, it works for CREATE SUBSCRIPTION sub CONNECTION xx \t, should we fix it?

Attach fixed this problem. Any thoughts?

--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.

Attachment Content-Type Size
v1-0001-Fix-tab-completation-for-CREATE-SUBSCRIPTION.patch text/x-patch 748 bytes

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-09-22 15:10:07 Re: proposal: possibility to read dumped table's name from file
Previous Message Andres Freund 2022-09-22 15:05:50 Re: [RFC] building postgres with meson - v13