| From: | Japin Li <japinli(at)hotmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Memory leak fix in psql |
| Date: | 2022-07-20 04:01:12 |
| Message-ID: | MEYP282MB16699C75CFAF8AD9C1CCD442B68E9@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 20 Jul 2022 at 11:51, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Wed, Jul 20, 2022 at 03:14:35AM +0000, tanghy(dot)fnst(at)fujitsu(dot)com wrote:
>> Your fix LGTM so please allow me to merge it in the attached patch.
>> Based on your rebased version, now this new patch version is V3.
>
> What about the argument of upthread where we could use a goto in
> functions where there are multiple pattern validation checks? Per se
> v4 attached.
+1. LGTM.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2022-07-20 04:08:05 | Re: Windows now has fdatasync() |
| Previous Message | David Rowley | 2022-07-20 03:56:53 | Re: Is select_outer_pathkeys_for_merge() too strict now we have Incremental Sorts? |