| From: | japin <japinli(at)hotmail(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: EXPLAIN/EXPLAIN ANALYZE REFRESH MATERIALIZED VIEW |
| Date: | 2021-01-09 02:02:46 |
| Message-ID: | MEYP282MB166996BD30E922F182FDC452B6AD0@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, 09 Jan 2021 at 09:38, Bharath Rupireddy wrote:
> On Fri, Jan 8, 2021 at 9:50 PM japin <japinli(at)hotmail(dot)com> wrote:
>> > Attaching v3 patches, please consider these for further review.
>> >
>>
>> I find that both the declaration and definition of match_matview_with_new_data()
>> have a tab between type and variable. We can use pgindent to fix it.
>> What do you think?
>>
>>
>> static void
>> match_matview_with_new_data(RefreshMatViewStmt *stmt, Relation matviewRel,
>> ^
>> Oid matviewOid, Oid OIDNewHeap, Oid relowner,
>> int save_sec_context, char relpersistence,
>> uint64 processed)
>> ^
>
> I ran pgindent on 0001 patch to fix the above. 0002 patch has no
> changes. If I'm correct, pgindent will be run periodically on master.
>
Thanks for your point out. I don't know before.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2021-01-09 02:04:42 | Re: [PATCH] Simple progress reporting for COPY command |
| Previous Message | Michael Paquier | 2021-01-09 01:46:46 | Re: Improper use about DatumGetInt32 |