From: | Japin Li <japinli(at)hotmail(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Richard Guo <guofenglinux(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Typo about subxip in comments |
Date: | 2022-11-13 15:02:06 |
Message-ID: | MEYP282MB166994010FABEFF20823BF76B6029@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, 12 Nov 2022 at 12:12, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Fri, Nov 11, 2022 at 2:45 PM Japin Li <japinli(at)hotmail(dot)com> wrote:
>> Maybe a wrong plural in XidInMvccSnapshot().
>>
>> * Make a quick range check to eliminate most XIDs without looking at the
>> * xip arrays.
>>
>> I think we should use "xip array" instead of "xip arrays".
>>
>
> I think here the comment is referring to both xip and subxip array, so
> it looks okay to me.
>
Yeah, it means xip in normal case, and subxip in recovery case.
>> Furthermore, if the snapshot is taken during recovery, the xip array is
>> empty, and we should check subxip array. How about changing "xip arrays"
>> to "xip or subxip array"?
>>
>
> I don't know if that is an improvement. I think we should stick to
> your initial proposed change.
Agreed. Let's focus on the initial proposed change.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2022-11-13 15:23:28 | Re: Making Bitmapsets be valid Nodes |
Previous Message | Pavel Stehule | 2022-11-13 15:01:21 | Re: Schema variables - new implementation for Postgres 15 |