From: | Japin Li <japinli(at)hotmail(dot)com> |
---|---|
To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Typo for xl_running_xacts |
Date: | 2022-11-17 08:47:44 |
Message-ID: | MEYP282MB16697A83B3940E289763D5EDB6069@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, 17 Nov 2022 at 16:22, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> On 17 Nov 2022, at 08:06, Japin Li <japinli(at)hotmail(dot)com> wrote:
>
>> I find some typo about xl_running_xacts in comments.
>> Attached a patch to fix those.
>
> Thanks, applied!
>
>> - * might look that we could use xl_running_xact's ->xids information to
>> + * might look that we could use xl_running_xacts->xids information to
>
> I'm not a native english speaker, but since xl_running_xacts refers to a name
> in this case and not an indication of plural possession, ending with a 's is
> correct even if it ends with an 's', so I instead changed this to
> "xl_running_xacts's".
Thanks, I found other places use "xl_running_xacs'",
such as "xl_running_xacts' oldestRunningXid" in snapbuild.c.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
From | Date | Subject | |
---|---|---|---|
Next Message | Richard Guo | 2022-11-17 08:56:34 | Re: Making Vars outer-join aware |
Previous Message | Daniel Gustafsson | 2022-11-17 08:22:09 | Re: Typo for xl_running_xacts |