| From: | Japin Li <japinli(at)hotmail(dot)com> |
|---|---|
| To: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Code clean for pre-9.0 binary upgrades in HeapTupleSatisfiesXXX() |
| Date: | 2022-09-19 07:54:57 |
| Message-ID: | MEYP282MB1669723A951DFDC4F5DC4DA4B64D9@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi hackers,
When I read the heapam_visibility.c, I found that there is some code in
HeapTupleSatisfiesXXX that has a similar code for pre-9.0 binary upgrades.
HeapTupleSatisfiesSelf, HeapTupleSatisfiesToast and HeapTupleSatisfiesDirty
have the same code for pre-9.0 binary upgrades. HeapTupleSatisfiesUpdate
has a similar code, except it returns TM_Result other than boolean.
HeapTupleSatisfiesMVCC also has a similar code like HeapTupleSatisfiesSelf,
expect it use XidInMVCCSnapshot other than TransactionIdIsInProgress.
The most different is HeapTupleSatisfiesVacuumHorizon.
Could we encapsulate the code for pre-9.0 binary upgrades? This idea comes from [1].
Any thoughts?
[1] https://www.postgresql.org/message-id/8a855f33-2581-66bf-85f7-0b99239edbda%40postgrespro.ru
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Sharma | 2022-09-19 08:13:46 | Re: confirmed_flush_lsn shows LSN of the data that has not yet been received by the logical subscriber. |
| Previous Message | Thomas Munro | 2022-09-19 07:40:11 | Re: Tree-walker callbacks vs -Wdeprecated-non-prototype |