Re: BUG #18134: ROW_COUNT do not set to 0 when psql's \gset command get no rows returned

From: Japin Li <japinli(at)hotmail(dot)com>
To: amutu(at)amutu(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #18134: ROW_COUNT do not set to 0 when psql's \gset command get no rows returned
Date: 2023-09-27 10:00:58
Message-ID: MEYP282MB1669351F137C61C19FA9749BB6C2A@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs


On Tue, 26 Sep 2023 at 09:26, PG Bug reporting form <noreply(at)postgresql(dot)org> wrote:
> The following bug has been logged on the website:
>
> Bug reference: 18134
> Logged by: amutu
> Email address: amutu(at)amutu(dot)com
> PostgreSQL version: 15.4
> Operating system: FreeBSD 13.2-RELEASE amd64
> Description:
>
> reproduce steps:
>
> $psql postgres
> psql (15.4)
> Type "help" for help.
>
> postgres=# select * from cmdq where status= 'new' \gset
> no rows returned for \gset
> postgres=# \echo :ROW_COUNT
> :ROW_COUNT
> postgres=# select * from cmdq;
> cmd | src_ip | worker | status | ts | id
>
> ---------+-----------+--------+--------+-------------------------------+----
> ls /tmp | 127.0.0.1 | | done | 2023-09-23 14:39:59.047309+08 |
> 1
> (1 row)
>
> postgres=# \echo :ROW_COUNT
> 1
> postgres=# select * from cmdq where status= 'new' \gset
> no rows returned for \gset
> postgres=# \echo :ROW_COUNT
> 1
> ------------------------------------------------
> from the psql doc:
> ROW_COUNT
> The number of rows returned or affected by the last SQL query, !!!!or 0 if
> the query failed or did not report a row count.!!!!

It seems SaveResultVariables() was lost when executing failed. Attached fix it.

Attachment Content-Type Size
fix-bug-18134.patch text/x-diff 480 bytes
unknown_filename text/plain 71 bytes

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Japin Li 2023-09-27 10:33:42 Re: Bug of psql meta-command \sf & \sv
Previous Message PG Bug reporting form 2023-09-27 10:00:01 BUG #18135: Incorrect memory access occurs when attaching a partition with an index