| From: | Japin Li <japinli(at)hotmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Memory leak fix in psql |
| Date: | 2022-07-19 13:08:53 |
| Message-ID: | MEYP282MB1669190449BB93DB10C612B5B68F9@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 19 Jul 2022 at 20:32, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Tue, Jul 19, 2022 at 06:41:13PM +0800, Japin Li wrote:
>> After looking around, I found psql/describe.c also has some memory leaks,
>> attached a patch to fix these leaks.
>
> Indeed. There are quite a bit of them, so let's fix all that. You
> have missed a couple of code paths in objectDescription().
Thanks for reviewing. Attached fix the memory leak in objectDescription().
Please consider v2 for further review.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fix-the-memory-leak-in-psql-describe.patch | text/x-patch | 16.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2022-07-19 13:18:01 | Re: pgsql: Default to hidden visibility for extension libraries where possi |
| Previous Message | Robert Haas | 2022-07-19 13:05:23 | Re: [PATCH] Introduce array_shuffle() and array_sample() |