From: | Japin Li <japinli(at)hotmail(dot)com> |
---|---|
To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
Cc: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, Zhihong Yu <zyu(at)yugabyte(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: fixing typo in comment for restriction_is_or_clause |
Date: | 2022-10-25 02:58:09 |
Message-ID: | MEYP282MB16690D52E52E024DCC49EF87B6319@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, 25 Oct 2022 at 10:48, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> On Tue, Oct 25, 2022 at 10:05 AM John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
> wrote:
>
>>
>> On Tue, Oct 25, 2022 at 12:19 AM Zhihong Yu <zyu(at)yugabyte(dot)com> wrote:
>> >
>> > Hi,
>> > When I was looking at src/backend/optimizer/util/restrictinfo.c, I found
>> a typo in one of the comments.
>>
>> Using "t" as an abbreviation for "true" was probably intentional, so not a
>> typo. There is no doubt what the behavior is.
>>
>> > I also took the chance to simplify the code a little bit.
>>
>> It's perfectly clear and simple now, even if it doesn't win at "code golf".
>>
>
> Agree with your point. Do you think we can further make the one-line
> function a macro or an inline function in the .h file? I think this
> function is called quite frequently during planning, so maybe doing that
> would bring a little bit of efficiency.
>
+1, same goes for restriction_is_securely_promotable.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
From | Date | Subject | |
---|---|---|---|
Next Message | Zhihong Yu | 2022-10-25 03:07:45 | Re: fixing typo in comment for restriction_is_or_clause |
Previous Message | Richard Guo | 2022-10-25 02:48:00 | Re: fixing typo in comment for restriction_is_or_clause |