Re: cleanup: Split long Makefile lists across lines and sort them

From: Japin Li <japinli(at)hotmail(dot)com>
To: "Jelte Fennema-Nio" <postgres(at)jeltef(dot)nl>
Cc: "zengman" <zengman(at)halodbtech(dot)com>, "pgsql-hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: cleanup: Split long Makefile lists across lines and sort them
Date: 2025-12-25 09:44:35
Message-ID: MEAPR01MB303152BAE0616EA0927B4D6EB6B3A@MEAPR01MB3031.ausprd01.prod.outlook.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 25 Dec 2025 at 10:07, "Jelte Fennema-Nio" <postgres(at)jeltef(dot)nl> wrote:
> On Wed Dec 24, 2025 at 3:31 PM CET, Jelte Fennema-Nio wrote:
>> Oops. Fixed in attached.
>
> I had accidentally included a trailing backspace in one of the lists. To
> my surprise that worked fine. Since these trailing separators result in
> smaller git diffs when a new item is added at the end of the list, I
> decided to put such trailing backslashes in all the lists in this patch.
> [3. text/x-patch; v3-0001-cleanup-Split-long-Makefile-lists-across-lines-an.patch]...

Small suggestion: the backslash on the last line isn't needed and can be removed.

This also aligns with the style used elsewhere.

--
Regards,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tender Wang 2025-12-25 11:00:02 Re: Extended Statistics set/restore/clear functions.
Previous Message Chao Li 2025-12-25 09:37:10 Re: cleanup: Split long Makefile lists across lines and sort them