Re: Cannot find a working 64-bit integer type on Illumos

From: Japin Li <japinli(at)hotmail(dot)com>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Cannot find a working 64-bit integer type on Illumos
Date: 2024-04-19 05:25:05
Message-ID: ME3P282MB316612F94343995360366AACB60D2@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On Fri, 19 Apr 2024 at 05:22, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Thu, Apr 18, 2024 at 6:09 PM Japin Li <japinli(at)hotmail(dot)com> wrote:
>> /home/japin/postgres/build/../src/include/lib/simplehash.h:1138:9: error: format '%llu' expects argument of type 'long long unsigned int', but argument 4 has type 'uint64' {aka 'long unsigned int'} [-Werror=format=]
>
> It seems my v1 patch's configure probe for INT64_FORMAT was broken.
> In the v2 patch I tried not doing that probe at all, and instead
> inviting <inttypes.h> into our world (that's the standardised way to
> produce format strings, which has the slight complication that we are
> intercepting printf calls...). I suspect that'll work better for you.

Yeah, the v2 patch fixed this problem.

--
Regards,
Japin Li

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2024-04-19 05:34:48 Re: WIP Incremental JSON Parser
Previous Message Bertrand Drouvot 2024-04-19 05:23:08 Re: promotion related handling in pg_sync_replication_slots()