| From: | Japin Li <japinli(at)hotmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Excessive LOG messages from replication slot sync worker |
| Date: | 2025-08-13 00:59:21 |
| Message-ID: | ME0P300MB0445DA158D9E1C7F7788F59BB62AA@ME0P300MB0445.AUSP300.PROD.OUTLOOK.COM |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 12, 2025 at 10:02:32PM +0900, Fujii Masao wrote:
> On Tue, Aug 12, 2025 at 8:06 PM Japin Li <japinli(at)hotmail(dot)com> wrote:
> > OTOH, I also update reorder buffer spill file path.
> >
> > $ git grep -E 'xid-.*-lsn.*spill'
> > src/backend/replication/logical/reorderbuffer.c: snprintf(path, MAXPGPATH, "%s/%s/xid-%u-lsn-%X-%X.spill",
>
> Should we also update LOGICAL_REWRITE_FORMAT to use %08X?
>
> That said, the number of places to change is growing, and we're drifting
> away from the original issue.... So I started thinking it might be better
> to simply applying Shveta's patch to revert the incorrect format change
> to fix the problem, and then discussing LSN-based filename standardization
> in a separate thread.
>
Agreed. See the new thread [1] for a discussion on this.
--
Best regards,
Japin Li
ChengDu WenWu Information Technology Co., LTD.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2025-08-13 02:17:52 | Re: Pathify RHS unique-ification for semijoin planning |
| Previous Message | Japin Li | 2025-08-13 00:56:12 | Standardize LSN-based filename |