Re: Update the LSN format in the comment example

From: Japin Li <japinli(at)hotmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Update the LSN format in the comment example
Date: 2025-08-14 02:21:56
Message-ID: ME0P300MB04459E96A54AEEB81E3EF369B635A@ME0P300MB0445.AUSP300.PROD.OUTLOOK.COM
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Aug 14, 2025 at 11:13:28AM +0900, Fujii Masao wrote:
> On Tue, Aug 12, 2025 at 7:36 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> >
> > On Tue, Aug 12, 2025 at 4:45 PM Japin Li <japinli(at)hotmail(dot)com> wrote:
> > >
> > > Hi, all
> > >
> > > Commit 2633dae2e487 standardized LSN formatting with zero-padding. However,
> > > a mistake was made (by me) in the example within a comment.
> > >
> > > This patch provides a fix for that.
> > >
> > > diff --git a/src/include/access/xlogdefs.h b/src/include/access/xlogdefs.h
> > > index 514f03df0b6..2397fb24115 100644
> > > --- a/src/include/access/xlogdefs.h
> > > +++ b/src/include/access/xlogdefs.h
> > > @@ -38,7 +38,7 @@ typedef uint64 XLogRecPtr;
> > > /*
> > > * Handy macro for printing XLogRecPtr in conventional format, e.g.,
> > > *
> > > - * printf("%X/08X", LSN_FORMAT_ARGS(lsn));
> > > + * printf("%X/%08X", LSN_FORMAT_ARGS(lsn));
> > > *
> > > * To avoid breaking translatable messages, we're directly applying the
> > > * LSN format instead of using a macro.
> >
> > LGTM.
> > Barring any objections, I'll commit the patch.
>
> Pushed. Thanks!
>

Thank you!

--
Best regards,
Japin Li
ChengDu WenWu Information Technology Co., LTD.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message KAZAR Ayoub 2025-08-14 02:24:50 Re: Speed up COPY FROM text/CSV parsing using SIMD
Previous Message Fujii Masao 2025-08-14 02:13:28 Re: Update the LSN format in the comment example