| From: | Luis Carril <luis(dot)carril(at)swarm64(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Option to dump foreign data in pg_dump |
| Date: | 2020-01-29 08:30:16 |
| Message-ID: | LEXPR01MB0591231525A7FADBAEF01A30E7050@LEXPR01MB0591.DEUPRD01.PROD.OUTLOOK.DE |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks for working on the comments. I noticed one behavior is
different when --table option is specified. When --table is specified
the following are not getting dumped:
CREATE SERVER foreign_server
I felt the above also should be included as part of the dump when
include-foreign-data option is specified.
Yes, it also happens on master. A dump of a foreign table using --table, which only dumps the table definition, does not include the extension nor the server.
I guess that the idea behind --table is that the table prerequisites should already exist on the database.
A similar behavior can be reproduced for a non foreign table. If a table is created in a specific schema, dumping only the table with --table does not dump the schema definition.
So I think we do not need to dump the server with the table.
Cheers
Luis M Carril
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2020-01-29 08:39:10 | Re: adding partitioned tables to publications |
| Previous Message | Konstantin Knizhnik | 2020-01-29 08:12:59 | Re: [Proposal] Global temporary tables |