Re: pgsql-server/src/bin/psql print.c

From: "Christopher Kings-Lynne" <chriskl(at)familyhealth(dot)com(dot)au>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Rod Taylor" <rbt(at)rbt(dot)ca>, <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql-server/src/bin/psql print.c
Date: 2002-11-04 02:14:44
Message-ID: GNELIHDDFBOCMGBFGEFOOEGKCEAA.chriskl@familyhealth.com.au
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Ah ok - so it's something that went in while I wasn't subscribed. Do you
now allow this as well?

CREATE TABLE test ();

Chris

> -----Original Message-----
> From: Tom Lane [mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us]
> Sent: Monday, 4 November 2002 10:04 AM
> To: Christopher Kings-Lynne
> Cc: Rod Taylor; pgsql-committers(at)postgresql(dot)org
> Subject: Re: [COMMITTERS] pgsql-server/src/bin/psql print.c
>
>
> "Christopher Kings-Lynne" <chriskl(at)familyhealth(dot)com(dot)au> writes:
> > Nup - DROP COLUMN (well at least the code I wrote) deliberately
> prevents you
> > from doing that!
>
> Yeah, but we ripped it out later, per this CVS log entry:
>
> 2002-09-28 16:00 tgl
>
> * src/: backend/access/common/tupdesc.c,
> backend/commands/tablecmds.c, backend/executor/execTuples.c,
> backend/executor/nodeAgg.c, backend/parser/parse_target.c,
> test/regress/expected/alter_table.out (REL7_3_STABLE),
> backend/access/common/tupdesc.c, backend/commands/tablecmds.c,
> backend/executor/execTuples.c, backend/executor/nodeAgg.c,
> backend/parser/parse_target.c,
> test/regress/expected/alter_table.out: Make the world at least
> somewhat safe for zero-column tables, and remove the special case
> in ALTER DROP COLUMN to prohibit dropping a table's last column.
>
> I forget the details of the discussion leading up to that, but we
> decided that prohibiting a DROP of a table's last column was creating
> so much ugliness that we should try to remove the restriction; and upon
> looking into it, there weren't *that* many places that would choke on
> it. So as of the last month or so, you can do it. I would not be
> surprised to find one or two more lurking problems with zero-column
> tables, but I'd rather fix those than have the weird special case.
>
> regards, tom lane
>

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2002-11-04 02:23:37 Re: pgsql-server/src/bin/psql print.c
Previous Message Tom Lane 2002-11-04 02:04:28 Re: pgsql-server/src/bin/psql print.c