Re: [PATCHES] Changes in /contrib/fulltextindex

From: "Christopher Kings-Lynne" <chriskl(at)familyhealth(dot)com(dot)au>
To: "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>, "Florian Helmberger" <f(dot)helmberger(at)uptime(dot)at>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] Changes in /contrib/fulltextindex
Date: 2002-07-12 01:34:19
Message-ID: GNELIHDDFBOCMGBFGEFOKEBICDAA.chriskl@familyhealth.com.au
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Yeah, I've got it Bruce - I still haven't had time to look into it and I
really don't know what to do about the backward compatibility issue. How do
I set up 2 identically named C functions with different parameter lists?

Chris

> -----Original Message-----
> From: Bruce Momjian [mailto:pgman(at)candle(dot)pha(dot)pa(dot)us]
> Sent: Friday, 12 July 2002 6:02 AM
> To: Florian Helmberger
> Cc: Tom Lane; Christopher Kings-Lynne; Hackers
> Subject: Re: [HACKERS] [PATCHES] Changes in /contrib/fulltextindex
>
>
>
> Florian, I haven't seen this patch yet. Did you send it in?
>
> ------------------------------------------------------------------
> ---------
>
> Florian Helmberger wrote:
> > Hi.
> >
> > > Huh? isalpha() *is* locale-aware according to the ANSI C spec.
> > > For instance, the attached test program finds 52 alpha characters
> > > in C locale and 114 in fr_FR locale under HPUX.
> > >
> > > I am not at all sure that this aspect of Florian's change is a good
> > > idea, as it appears to eliminate locale-awareness in favor of a hard
> > > coded delimiter list.
> >
> > Just tried your example - you're right of course! I will remove the hard
> > coded delimited list and replace it with the proper calls as
> shown in the
> > code you've sent.
> >
> > Florian
> >
> >
> >
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 1: subscribe and unsubscribe commands go to majordomo(at)postgresql(dot)org
> >
> >
> >
>
> --
> Bruce Momjian | http://candle.pha.pa.us
> pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
> + If your life is a hard drive, | 830 Blythe Avenue
> + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Christopher Kings-Lynne 2002-07-12 01:35:43 Re: [HACKERS] bugzilla.pgaccess.org
Previous Message Christopher Kings-Lynne 2002-07-12 01:29:09 Re: Should this require CASCADE?