Re: basebackup: do not verify checksums on pages written before enabling checksums

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
Cc: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, Yilin Zhang <jiezhilove(at)126(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: basebackup: do not verify checksums on pages written before enabling checksums
Date: 2026-08-18 12:42:17
Message-ID: FE7457FE-6108-422C-98AB-03E139B1BCFB@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 18 Aug 2026, at 14:39, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:

> Shouldn't hit be incremented only when the injection point is attached?

Good point, will fix.

> + checksum ^= checksum;
>
> That's same as "checksum = 0". That works because 0 is not a valid value but
> was the intend to "checksum ^= 1"? to express that we want a different checksum?

Ugh, sorry, I didn't notice that I hadn't replaced my debugcode before
generating the patch, I blame the lack of caffeine this morning.

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message ZizhuanLiu X-MAN 2026-08-18 12:49:18 Re: examine_variable ignored CollateExpr
Previous Message Bertrand Drouvot 2026-08-18 12:39:42 Re: basebackup: do not verify checksums on pages written before enabling checksums