| From: | Greg Burd <greg(at)burd(dot)me> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Add tests for Bitmapset |
| Date: | 2025-09-17 14:53:26 |
| Message-ID: | FD75B3A5-F432-4A9F-8E4A-E98B5614765D@greg.burd.me |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sep 17 2025, at 9:55 am, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Sep 17, 2025 at 9:18 AM Greg Burd <greg(at)burd(dot)me> wrote:
>> > +static void
>> > +elog_bitmapset(int elevel, const char *label, const Bitmapset *bms)
>> >
>>
>> I added a function bms_values() that prints out the values contained in
>> a bitmapset and changed a few tests to use it. I removed the
>> elog_bitmapset() as it isn't being used and now that it's easy to output
>> the set in SQL why keep it for debugging?
>
> How about using outBitmapset() which already exists?
Robert,
Thanks for chiming in, not sure how I missed that one. :)
> --
> Robert Haas
> EDB: http://www.enterprisedb.com
I've updated the hash value for 32bit systems and changed the
bms_values() function to use outBitmapset() via bmsToString().
best.
-greg
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Add-a-module-that-tests-Bitmapset.patch | application/octet-stream | 69.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2025-09-17 14:59:55 | Re: REPACK and naming |
| Previous Message | Joe Conway | 2025-09-17 14:50:34 | Re: Schedule for PG 18 RC and GA releases |