| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Arseniy Mukhin <arseniy(dot)mukhin(dot)dev(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments |
| Date: | 2025-11-11 06:28:43 |
| Message-ID: | FD184796-6F6E-4D08-9320-9DD89D96B178@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Nov 10, 2025, at 17:28, Aleksander Alekseev <aleksander(at)tigerdata(dot)com> wrote:
>
>> 1. I just ran the patched pgindent against a random file, then I got a lot diffs like:
>>
>> ```
>> /*
>> - * Direct advancement: avoid waking non-caught up backends that
>> - * aren't interested in our notifications.
>> + * Direct advancement: avoid waking non-caught up backends that aren't
>> + * interested in our notifications.
>> */
>> ```
>
> I'm not sure if this is part of the PostgreSQL code base either. My
> best guess is that something is wrong with whitespaces here (tabs vs
> spaces). We have plenty of multiline comments like this and from what
> I can tell they are processed correctly.
I recalled that. I ran pgindent on a file from a patch I was reviewing, so, the file was not pgindent-ed yet at the time.
I just tried to run the patched pgindent on several files and no diff generated. So this comment is resolved.
Regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2025-11-11 06:42:34 | Re: Fix ALTER TABLE DROP EXPRESSION with inheritance hierarchy |
| Previous Message | Chao Li | 2025-11-11 06:13:44 | Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions |