| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com> |
| Cc: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: datachecksums: handle invalid and dropped databases during enable |
| Date: | 2026-08-03 15:01:47 |
| Message-ID: | FC05C972-4C57-4BD3-A78C-87608A2C0FC5@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 3 Aug 2026, at 14:14, Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com> wrote:
> On Fri, 31 Jul 2026 at 03:32, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com <mailto:zsolt(dot)parragi(at)percona(dot)com>> wrote:
>> We could improve this either by adding your patch, or by removing
>> ErrorOnInvalidDatabases, but adding this patch seems to be safer to
>> me.
>
> I lean the same way.
After looking at this and sleeping on it, I think I agree. The case should be
pretty rare to hit but if done this approach seems like the right one. I'll go
make it so, backpatched to 19.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Philip Alger | 2026-08-03 15:15:39 | Re: [PATCH] Add pg_get_trigger_ddl() to retrieve the CREATE TRIGGER statement |
| Previous Message | Tom Lane | 2026-08-03 15:01:09 | Re: Catcache rehash hits MaxAllocSize (1GB) and errors with "invalid memory alloc request size" on very large numbers of relations |