| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Rename of varatt_external to varatt_external_oid |
| Date: | 2026-09-04 06:20:48 |
| Message-ID: | FBE0E804-F1F5-4AD5-8A46-445F26B097A7@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Sep 4, 2026, at 09:20, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Fri, Sep 04, 2026 at 08:43:37AM +0800, Chao Li wrote:
>> I tried to review this patch, but “git am” failed on the current
>> HEAD (2b3d11aaed8). Would you please rebase?
>
> Oops. Sorry for the incorrect rebase blurp caused by 2b3d11aaed89.
> The attached should work better.
> --
> Michael
> <v2-0001-Rename-varatt_external-to-varatt_external_oid.patch>
I briefly went through the referenced patch as well as Tom’s comment, so I have no objection to this renaming.
The code changes in v2 look good to me.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Henri GASC | 2026-09-04 06:43:06 | Re: [SQL/PGQ] Native executor for Graph query |
| Previous Message | shveta malik | 2026-09-04 06:14:48 | Re: Crashes on a partition whose concurrent detach never finished |