| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Reducing connection overhead in pg_upgrade compat check phase |
| Date: | 2023-09-14 08:48:45 |
| Message-ID: | FA58EDD7-97F8-418E-BE4A-511616DB8ADB@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 13 Sep 2023, at 16:12, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> The alignment of this output looks a bit funny:
>
> ...
> Checking for prepared transactions ok
> Checking for contrib/isn with bigint-passing mismatch ok
> Checking for data type usage checking all databases
> ok
> Checking for presence of required libraries ok
> Checking database user is the install user ok
> ...
I was using the progress reporting to indicate that it hadn't stalled for slow
systems, but it's not probably not all that important really. Removed such
that "ok" aligns.
> Also, you should put gettext_noop() calls into the .status = "Checking ..."
> assignments and arrange to call gettext() where they are used, to maintain
> the translatability.
Ah, yes of course. Fixed.
--
Daniel Gustafsson
| Attachment | Content-Type | Size |
|---|---|---|
| v9-0001-pg_upgrade-run-all-data-type-checks-per-connectio.patch | application/octet-stream | 37.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amul Sul | 2023-09-14 09:04:31 | Re: ALTER COLUMN ... SET EXPRESSION to alter stored generated column's expression |
| Previous Message | Damir Belyalov | 2023-09-14 08:44:08 | Re: Redundant Unique plan node for table with a unique index |