| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Karina Litskevich <litskevichkarina(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: doc: Improve description of io_combine_limit and io_max_combine_limit GUCs |
| Date: | 2025-11-05 23:59:18 |
| Message-ID: | F98C353B-F413-4F90-B66C-D25FB5CDC366@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Nov 5, 2025, at 21:58, Karina Litskevich <litskevichkarina(at)gmail(dot)com> wrote:
>
>
>
> I'm attaching these changes as a separate patch just in case. You can
> squash them if you like. Not sure what to do with the commitfest entry.
> Should I change it back to Needs review?
>
> Best regards,
> Karina Litskevich
> Postgres Professional: http://postgrespro.com/
> <v2-0002-doc-Fix-description-of-GUCs-with-PGC_POSTMASTER-c.patch><v2-0001-doc-Improve-description-of-io_combine_limit-and-i.patch>
```
- This parameter can only be set in the <filename>postgresql.conf</filename>
- file or on the server command line.
+ This parameter can only be set at server start.
```
I think this change will lose information. Actually, I think that even the original message is not accurate enough. For PGC_POSTMASTER parameters, there are 3 ways to update their values:
* Editing postgres.conf
* server command line
* ALTER SYSTEM, updating postgres.auto.conf
But all require a server restart. The original doc misses “ALTER SYSTEM”, and your change just hides all methods. So I would suggest:
```
This parameter can only be set at server start (for example, in postgresql.conf, via ALTER SYSTEM, or on the server command line).
```
Fujii-san, what do you think?
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2025-11-06 00:48:18 | Re: Logical Replication of sequences |
| Previous Message | Andrew Kim | 2025-11-05 23:49:47 | Re: Proposal for enabling auto-vectorization for checksum calculations |