Re: Small patch to improve safety of utf8_to_unicode().

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Small patch to improve safety of utf8_to_unicode().
Date: 2026-06-28 22:29:47
Message-ID: F865EE32-6C05-4CA1-8DEC-54E4A7C5CE0D@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Jun 27, 2026, at 22:02, Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
>
> On Fri, 2026-06-26 at 12:38 +0800, Chao Li wrote:
>> Sounds like 0001 will be back patched. In that case, the commit
>> message "defend against invalid UTF8” seems too broad. Does it make
>> sense to add some brief description about the defend behavior to the
>> function header comment and the commit message?
>
> Right. Would "defend against truncated byte sequences" or "defend
> against truncated UTF8" be better wording?
>
> Regards,
> Jeff Davis
>

Yes, I think they are better. “Truncated” is more specific than “invalid”. I'm slightly more keen on the second phrase.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2026-06-28 23:01:07 Re: DOCS - "Get Object DDL Functions" table improvements
Previous Message Daniel Gustafsson 2026-06-28 22:05:48 Re: doc: fix two id/xreflabel inconsistencies in config.sgml